Voldemort and his Death Eaters would still be the main enemies. But now, Harry's guns would pose a new threat to them. They might not be used to dealing with such Muggle - like weapons, even if they are magically enhanced.
Well, perhaps Harry could use his magical knowledge to create enchanted guns. He might combine spells with gunsmithing to make weapons that can shoot magical bullets. For example, bullets that can turn into Patronuses to defend against Dementors.
There could be a new dark wizard or witch who is jealous of the Potter family's legacy. They might target Harry Potter's daughter to try and bring down the family name and prove their own power.
The unique blend of two very different worlds. Harry Potter is all about magic, wands, and spells, while gunsmithing is a Muggle - based, mechanical craft. When combined, it creates a whole new set of possibilities for stories, like creating magical guns or using gunsmithing techniques to enhance magical items.
The Death Eaters could still be a major threat. Even with Voldemort gone, some of them might be trying to revive the dark ways and see the wizard king as a big obstacle in their path.
Hermione would be a likely colleague. She's highly intelligent and could be teaching a subject like Ancient Runes or Arithmancy. Ron could also be there, perhaps as a flying instructor or teaching something related to magical creatures. Neville might be a Herbology professor, given his love and talent for that subject. Luna could be teaching something really unique, like the study of magical creatures that are often overlooked or misunderstood.
Perhaps Hagrid could be his mentor. Hagrid has a lot of knowledge about magical creatures and their parts, which could be useful for Harry in his blacksmithing. He could show Harry how to use things like dragon scales or unicorn hairs in his creations.
In some fanfictions, it could be Sirius Black. Some fans like to imagine that Sirius had a deeper connection to James Potter's family than just being best friends. They might create a scenario where there was some sort of magic or prophecy involved that made Sirius more than just Harry's godfather, but his actual father in this alternate story line.
Hermione would definitely be one of his top allies. Her intelligence and knowledge of magic and history would be invaluable in helping Harry rule. She could advise him on laws and policies, especially those related to education and the treatment of non - human magical beings. Ron would also be an ally. His loyalty and his understanding of the wizarding world's less - sophisticated side could help Harry connect with the common wizards.
In some fanfictions, it could be an original character created by the author. Maybe a witch who was the result of an affair that his father had before he married his mother. However, this is completely against the canon of the original books, but in the world of fanfiction, anything is possible.
Hermione would definitely be one of his allies. She is smart and resourceful and would be able to help Harry navigate the new political and magical situations he faces as a prince. For example, she could research ancient laws and prophecies related to his new status.